Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Joe Death Sound and Death Message (It is so Joever) #3798

Merged
merged 24 commits into from
Jul 18, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jul 5, 2023

About the pull request

This PR gives Working joes a unique death sound and death message....upon death.

TODO:

  • Add framework for implementation.
  • Find appropriate sounds for Working Joe death
  • (Optional) Have a random death noise be picked to be played
  • Implement a death message for Working Joes

Explain why it's good for the game

For the same reasons we added the initial Working Joe audible emotes, this will add more depth to the Joes and make them even more uncanny. (Also default death message makes no sense as Working Joe eyes are already dead and lifeless.)

Testing Photographs and Procedure

Screenshots & Videos
YouAlwaysKnew.mp4

Example of default death noise playing, what most will hear.

Changelog

🆑
add: Working Joes now have a unique death message. Credit to Quickload for the message.
soundadd: Working Joes now have a death rattle. Credit to Quickload for shifting through Alien Isolation audio files.
qol: Things that die with intent eyes now lose color in their eyes on death.
/:cl:

@github-actions github-actions bot added Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players labels Jul 5, 2023
@Ben10083
Copy link
Contributor Author

Ben10083 commented Jul 5, 2023

This should be good enough to put up for review, other sounds for death occur at about 5% chance

@Ben10083 Ben10083 marked this pull request as ready for review July 5, 2023 20:56
@Ben10083 Ben10083 marked this pull request as draft July 5, 2023 22:31
@Ben10083 Ben10083 marked this pull request as ready for review July 5, 2023 22:59
@Ben10083 Ben10083 requested a review from Zonespace27 July 6, 2023 16:08
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 10, 2023
@Ben10083 Ben10083 requested a review from harryob July 10, 2023 18:19
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 18, 2023
@harryob harryob added this pull request to the merge queue Jul 18, 2023
Merged via the queue into cmss13-devs:master with commit d8c1bf9 Jul 18, 2023
@Ben10083 Ben10083 deleted the Joe_Death branch July 18, 2023 18:19
cm13-github added a commit that referenced this pull request Jul 18, 2023
github-actions bot added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants